netdev - Re: [PATCH net-next] net/mlx4_en: mlx4_en_set_settings() always fails when autoneg is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141121.150850.1419027477033247999.davem@davemloft.net>
Date:	Fri, 21 Nov 2014 15:08:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	amirv@...lanox.com
Cc:	ogerlitz@...lanox.com, yevgenyp@...lanox.com,
	netdev@...r.kernel.org, saeedm@...lanox.com
Subject: Re: [PATCH net-next] net/mlx4_en: mlx4_en_set_settings() always
 fails when autoneg is set

From: Amir Vadai <amirv@...lanox.com>
Date: Thu, 20 Nov 2014 14:19:44 +0200

> From: Saeed Mahameed <saeedm@...lanox.com>
> 
> Fix ethtool set settings to not check AUTONEG_ENABLE
> 
> mlx4_en_set_settings should not check if cmd->autoneg == AUTONEG_ENABLE,
> cmd->autoneg can be enabled by default and this check will fail other settings requests.
> mlx4_en driver doesn't support changing autoneg value, but shouldn't fail the request
> in case cmd->autoneg was set.
> 
> Fixes: d48b3ab ("net/mlx4_en: Use PTYS register to set ethtool settings (Speed)")
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> Signed-off-by: Amir Vadai <amirv@...lanox.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html