netdev - Re: [PATCH] vxlan: move listen socket creation from workqueue to vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141121.171131.1339829257521697510.davem@davemloft.net>
Date:	Fri, 21 Nov 2014 17:11:31 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mleitner@...hat.com
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	pshelar@...ira.com
Subject: Re: [PATCH] vxlan: move listen socket creation from workqueue to
 vxlan_open

From: Marcelo Ricardo Leitner <mleitner@...hat.com>
Date: Thu, 20 Nov 2014 10:33:32 -0200

> But this doesn't apply to vxlan_open() scenario. We can unlock/lock
> in there safely and, with that, we can return a better error value
> to the user if that's the case.

This is not safe.

Now nothing prevents another parallel open of this vxlan device to
occur while you dropped the RTNL semaphore.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html