netdev - Re: [patch net-next] i40e: remove dead fdb code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141121074401.GB1872@nanopsycho.orion>
Date:	Fri, 21 Nov 2014 08:44:01 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	jeffrey.t.kirsher@...el.com, bruce.w.allan@...el.com,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	gregory.v.rose@...el.com, matthew.vick@...el.com,
	john.ronciak@...el.com, mitch.a.williams@...el.com,
	linux.nics@...el.com, e1000-devel@...ts.sourceforge.net
Subject: Re: [patch net-next] i40e: remove dead fdb code

Thu, Nov 20, 2014 at 06:39:46PM CET, jesse.brandeburg@...el.com wrote:
>On Thu, 20 Nov 2014 14:10:29 +0100
>Jiri Pirko <jiri@...nulli.us> wrote:
>
>> This code is not used now and also it contains some weird ifdefs. So
>> remove it for now. It can be added when needed.
>> 
>
>First, thanks for looking at our code.
>
>but, NAK, the code just needs to have the #ifdefs removed.
>
>In addition the fdb_del and fdb_dump functions are un-necessary and
>were submitted by mistake.

So it need more than ifdefs removal. That's what I thought :)

>
>I will draft up a patch today and send it (and Jeff can take it through
>Jeff Kirsher's i40e tree, if thats okay with DaveM)
>
>Thanks, 
> Jesse
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html