netdev - RE: [PATCH net] cxgb4 : Fix DCB priority groups being returned in wrong order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <525DB349B3FB5444AE057A887CB2A8D8D85F42@nice.asicdesigners.com>
Date:	Fri, 21 Nov 2014 01:16:29 +0000
From:	Anish Bhatt <anish@...lsio.com>
To:	Anish Bhatt <anish@...lsio.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	Hariprasad S <hariprasad@...lsio.com>
Subject: RE: [PATCH net] cxgb4 : Fix DCB priority groups being returned in
 wrong order

> -----Original Message-----
> From: Anish Bhatt [mailto:anish@...lsio.com]
> Sent: Thursday, November 20, 2014 2:46 PM
> To: netdev@...r.kernel.org
> Cc: davem@...emloft.net; Hariprasad S; Anish Bhatt
> Subject: [PATCH net] cxgb4 : Fix DCB priority groups being returned in wrong
> order
> 
> Peer priority groups were being reversed, but this was missed in the
> previous fix sent out for this issue.
> 
> Fixes :	ee7bc3cdc270 ('cxgb4 : dcb open-lldp interop fixes')
> 
> Signed-off-by: Anish Bhatt <anish@...lsio.com>
> ---
>  drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> index cca6049..d8e60b3 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> @@ -1082,7 +1082,7 @@ static int cxgb4_cee_peer_getpg(struct net_device
> *dev, struct cee_pg *pg)
>  	pgid = be32_to_cpu(pcmd.u.dcb.pgid.pgid);
> 
>  	for (i = 0; i < CXGB4_MAX_PRIORITY; i++)
> -		pg->prio_pg[i] = (pgid >> (i * 4)) & 0xF;
> +		pg->prio_pg[7 - i] = (pgid >> (i * 4)) & 0xF;
> 
>  	INIT_PORT_DCB_READ_PEER_CMD(pcmd, pi->port_id);
>  	pcmd.u.dcb.pgrate.type = FW_PORT_DCB_TYPE_PGRATE; @@ -
> 1094,7 +1094,8 @@ static int cxgb4_cee_peer_getpg(struct net_device *dev,
> struct cee_pg *pg)
>  	}
> 
>  	for (i = 0; i < CXGB4_MAX_PRIORITY; i++)
> -		pg->pg_bw[i] = pcmd.u.dcb.pgrate.pgrate[i];
> +		pg->pg_bw[7 - i] = pcmd.u.dcb.pgrate.pgrate[
> +			(pgid >> (i * 4)) & 0xF];
> 
>  	return 0;
>  }
> --
> 2.1.3

Just sent out a v2, Dave please ignore this patch.
-Anish
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html