lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 21 Nov 2014 10:17:19 -0800
From:	Pravin Shelar <>
To:	Joe Stringer <>
Cc:	"" <>,
	Linux Netdev List <>
Subject: Re: [PATCHv10 ovs 03/15] datapath: Add 'is_mask' to ovs_nla_put_flow().

On Thu, Nov 20, 2014 at 4:15 PM, Joe Stringer <> wrote:
> On 13 November 2014 11:17, Joe Stringer <> wrote:
>> This function previously hid the 'is_mask' parameter from the callers,
>> which actually have better knowledge about whether it is serializing a
>> mask or not. Expose this parameter to the callers. This allows the same
>> function to be called to serialize masked keys as well as masked keys.
>> To serialize an unmasked key:
>> ovs_nla_put_flow(key, key, skb, false);
>> To serialize a masked key:
>> ovs_nla_put_flow(mask, key, skb, false);
>> To serialize a mask:
>> ovs_nla_put_flow(key, mask, skb, true);
> I'll add helpers for each of these functions:
> ovs_nla_put_{un,}masked_key(), ovs_nla_put_mask() in the next version.

sounds good to me.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists