netdev - Re: [PATCH 5/6] net/core: support compiling out splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20141122230731.GC24429@thin>
Date:	Sat, 22 Nov 2014 15:07:32 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Pieter Smith <pieter@...sman.nl>
Cc:	Willem de Bruijn <willemb@...gle.com>,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	Thomas Graf <tgraf@...g.ch>,
	"open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
	Miklos Szeredi <mszeredi@...e.cz>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Daniel Borkmann <dborkman@...hat.com>,
	Jan Beulich <JBeulich@...e.com>,
	open list <linux-kernel@...r.kernel.org>,
	Paul Durrant <Paul.Durrant@...rix.com>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [PATCH 5/6] net/core: support compiling out splice

[Please don't top-post.]

On Sat, Nov 22, 2014 at 11:50:51PM +0100, Pieter Smith wrote:
> splice exports a structure that is used by skbuf. Mocking out a function is
> straightforward. To my knowledge there is no elegant way of mocking out a
> splice_operations struct. I directly modified the code to prevent linking
> against the struct. Do you know of a better technique to get the same
> result?

No, I don't.  The approach you took seems fine; I'm just saying that you
need to explain the need for it in the commit message.

- JosH Triplett
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html