lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Nov 2014 13:48:09 -0500 (EST) From: David Miller <davem@...emloft.net> To: richardcochran@...il.com Cc: ben@...adent.org.uk, netdev@...r.kernel.org, stefan.sorensen@...ctralink.com Subject: Re: [PATCH net-next] vlan: Pass ethtool get_ts_info queries to real device. From: Richard Cochran <richardcochran@...il.com> Date: Sun, 23 Nov 2014 17:05:35 +0100 > On Sun, Nov 23, 2014 at 03:15:12AM +0000, Ben Hutchings wrote: >> This assumes that the same PTP capabilities apply to VLAN-tagged frames. >> I don't think it's at all safe to assume that RX filter modes other than >> HWTSTAMP_FILTER_ALL will include VLAN-tagged frames. I think it is >> necessary to define additional modes that explicitly include VLAN-tagged >> frames. > > Unsafe? How? > > Do you mean that some HW cannot identify and time stamp PTP frames > when VLAN tagged? That is surely disappointing for people who shell > out money for such cards, but it is hardly unsafe. Ben, you will have to provide a concrete example of a chip that will do the wrong thing with Richard's change. Hypotheticals won't cut it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists