netdev - Re: [PATCH net-next] ipv6: coding style improvements (remove assignment in if statements)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 23 Nov 2014 14:29:19 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ipm@...rality.org.uk
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv6: coding style improvements (remove
 assignment in if statements)

From: Ian Morris <ipm@...rality.org.uk>
Date: Sat, 22 Nov 2014 12:02:05 +0000

> diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
> index 7226697..7d7733a 100644
> --- a/net/ipv6/ip6mr.c
> +++ b/net/ipv6/ip6mr.c
> @@ -2410,8 +2410,7 @@ static int mr6_msgsize(bool unresolved, int maxvif)
>  		      + nla_total_size(0)	/* RTA_MULTIPATH */
>  		      + maxvif * NLA_ALIGN(sizeof(struct rtnexthop))
>  						/* RTA_MFC_STATS */
> -		      + nla_total_size(sizeof(struct rta_mfc_stats))
> -		;
> +		      + nla_total_size(sizeof(struct rta_mfc_stats));
>  
>  	return len;
>  }

This first of all has absolutely nothing to do with your patch, it is
not eliminating an assignment from an if statement.

Second of all, this layout is absolutely intentional.

It makes it such that when new netlink attributed are added, the
patch to add them to this calculation is minimized to one line.

Therefore, please keep that semicolon on a line all by itself.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html