lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Nov 2014 12:56:31 -0800 From: Joe Perches <joe@...ches.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: Amir Vadai <amirv@...lanox.com>, Ben Hutchings <ben@...adent.org.uk>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH net-next] mlx4: fix mlx4_en_set_rxfh() On Sun, 2014-11-23 at 09:05 -0800, Eric Dumazet wrote: > On Sun, 2014-11-23 at 18:53 +0200, Amir Vadai wrote: > > > */ > > > for (i = 0; i < priv->rx_ring_num; i++) { > > > + if (!ring_index) > > > + continue; > > > > Why didn't you put the whole loop under the 'if'? > > To avoid adding one indentation on the block, and ease this code review. > > This is hardly fast path, and compiler does the optim for us anyway. It might have been more sensible to use break instead of continue -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists