netdev - Re: [PATCH 2/2] sh_eth: Fix asynchronous external abort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1416795597.7215.76.camel@decadent.org.uk>
Date:	Mon, 24 Nov 2014 02:19:57 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Simon Horman <horms@...ge.net.au>
Cc:	Yoshihiro Kaneko <ykaneko0929@...il.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Magnus Damm <magnus.damm@...il.com>, linux-sh@...r.kernel.org
Subject: Re: [PATCH 2/2] sh_eth: Fix asynchronous external abort

On Mon, 2014-11-24 at 10:18 +0900, Simon Horman wrote:
> Hi Kaneko-san, Hi All,
> 
> On Thu, Nov 13, 2014 at 04:02:15PM +0900, Yoshihiro Kaneko wrote:
> > From: Mitsuhiro Kimura <mitsuhiro.kimura.kc@...esas.com>
> > 
> > When clock is disabled, Ethernet register access raise Bus error.
> 
> I have spoken with Kimura-san and the problem may be reproduced by
> calling ethtool with -s of -G while the network interface is down.
> 
> e.g.:
> ifconfig eth0 down
> ethtool -G eth0 rx 512
> 
> I have confirmed that the problem above appears in net-next
> and appears to be resolved with this patch and the previous on
> in this series (which seems to be a dependency) applied.
[...]

The change to sh_eth_set_ringparam() is fine.  But I don't think it is
correct for sh_eth_set_settings() to fail when the interface is down.
It should behave like sh_eth_set_ringparam() - validate and remember the
requested settings, so they can be applied when the interface is brought
up.

When drivers have their own rules about when certain configuration
operations can and can't be used, we end up with messes like WEXT.

Ben.

-- 
Ben Hutchings
Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)