netdev - Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141124214926.GA9371@smipidev>
Date:	Mon, 24 Nov 2014 22:49:26 +0100
From:	Pieter Smith <pieter@...sman.nl>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	josh@...htriplett.org,
	Richard Weinberger <richard.weinberger@...il.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Bertrand Jacquin <beber@...eeweb.net>,
	Oleg Nesterov <oleg@...hat.com>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Eric Dumazet <edumazet@...gle.com>,
	蔡正龙 <zhenglong.cai@...c.com.cn>,
	Jeff Layton <jlayton@...chiereds.net>,
	Tom Herbert <therbert@...gle.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Miklos Szeredi <miklos@...redi.hu>,
	Peter Foley <pefoley2@...oley.com>,
	Hugh Dickins <hughd@...gle.com>,
	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Mel Gorman <mgorman@...e.de>, Matt Turner <mattst88@...il.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	"open list:FUSE: FILESYSTEM..." <fuse-devel@...ts.sourceforge.net>,
	"Luis R. Rodriguez" <mcgrof@...e.com>,
	Catalina Mocanu <catalina.mocanu@...il.com>,
	Fabian Frederick <fabf@...net.be>, Thomas Graf <tgraf@...g.ch>,
	Paul Durrant <Paul.Durrant@...rix.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Jan Beulich <JBeulich@...e.com>,
	Willem de Bruijn <willemb@...gle.com>,
	Iulia Manda <iulia.manda21@...il.com>,
	"open list:ABI/API" <linux-api@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Daniel Borkmann <dborkman@...hat.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

On Mon, Nov 24, 2014 at 12:22:14PM -0800, Greg KH wrote:
> On Mon, Nov 24, 2014 at 12:14:50PM -0800, josh@...htriplett.org wrote:
> > > I would, again, argue that stuff like __splice_p() not be implemented at
> > > all please.  It will only cause a huge proliferation of stuff like this
> > > that will not make any sense, and only cause a trivial, if any, amount
> > > of code savings.
> > > 
> > > I thought you were going to not do this type of thing until you got the
> > > gcc optimizer working for function callbacks.
> > 
> > Compared to the previous patchset, there are now only two instances of
> > ifdefs outside of the splice code for this, and this is one of them.  In
> > this case, the issue is no longer about making the code for this
> > splice_read function disappear, but rather to eliminate a reference to a
> > bit of splice functionality (used *inside* the FUSE splice code) that
> > will not work without SPLICE_SYSCALL.
> > 
> > Would you prefer to see this specific case handled via an #ifdef in
> > fs/fuse/dev.c rather than introducing a __splice_p that people might be
> > inclined to propagate?  That'd be fine; the code could simply wrap
> > fuse_dev_splice_read in an #ifdef and have the #else define a NULL
> > fuse_dev_splice_read.
> 
> Yes, I would prefer that, but I'm not the fuse maintainer.
> 
> thanks,
> 
> greg k-h

Okay. I'll do my part to prevent the type of proliferation guaranteed to rate
high on the respected K-H icky-scale. __splice_p() goes the way of the dodo
in favor of the solution presented by Josh.

I pray that the Gods of fuse maintenance will look favorable upon the result.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html