netdev - Re: [PATCH 08/17] {macvtap,tun}_get_user(): switch to iov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Nov 2014 01:06:12 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	David Miller <davem@...emloft.net>, torvalds@...ux-foundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	target-devel@...r.kernel.org, nab@...ux-iscsi.org,
	hch@...radead.org
Subject: Re: [PATCH 08/17] {macvtap,tun}_get_user(): switch to iov_iter

On Mon, 2014-11-24 at 00:27 +0000, Ben Hutchings wrote:
> On Sat, 2014-11-22 at 04:33 +0000, Al Viro wrote:
[...]
> Does skb_copy_datagram_from_iter() really need a len parameter?  Here it
> is equal to iov_iter_count(from).
[...]
> Again len is equal to iov_iter_count(from), so I think that parameter is
> redundant.

Having read further patches, I see that unix_stream_sendmsg() is the one
exception where the length parameter is different.  But maybe the common
case (len = iter_iov_count(iov)) deserves a wrapper function?

Ben.

-- 
Ben Hutchings
Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)