lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 24 Nov 2014 14:33:00 +0100
From:	Jiri Pirko <>
To:	Jamal Hadi Salim <>
Subject: Re: [patch net-next] tc_vlan: fix type of tcfv_push_vid

Mon, Nov 24, 2014 at 02:25:52PM CET, wrote:
>On 11/24/14 05:30, Jiri Pirko wrote:
>>Should be u16. So fix it to kill the sparse warning.
>>Fixes: c7e2b9689ef8136 "sched: introduce vlan action"
>>Signed-off-by: Jiri Pirko <>
>>  include/net/tc_act/tc_vlan.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>diff --git a/include/net/tc_act/tc_vlan.h b/include/net/tc_act/tc_vlan.h
>>index c809c1d..93b70ad 100644
>>--- a/include/net/tc_act/tc_vlan.h
>>+++ b/include/net/tc_act/tc_vlan.h
>>@@ -18,7 +18,7 @@
>>  struct tcf_vlan {
>>  	struct tcf_common	common;
>>  	int			tcfv_action;
>>-	__be16			tcfv_push_vid;
>>+	u16			tcfv_push_vid;
>>  	__be16			tcfv_push_proto;
>User space sends you this in be, no? I thought it was fine
>the way it is. Isnt __be16 just an annotation?

No, userspace sends this in host. Therefore we should store it in host,
not in be. It is just an annotation.

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists