netdev - Re: [PATCH net-next] gre: Set inner mac header in gro complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141125.143530.1055990826405505003.davem@davemloft.net>
Date:	Tue, 25 Nov 2014 14:35:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	therbert@...gle.com, linux@...m.de, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] gre: Set inner mac header in gro complete

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 25 Nov 2014 09:57:21 -0800

> On Tue, 2014-11-25 at 09:30 -0800, Tom Herbert wrote:
>> Set the inner mac header to point to the GRE payload when
>> doing GRO. This is needed if we proceed to send the packet
>> through GRE GSO which now uses the inner mac header instead
>> of inner network header to determine the length of encapsulation
>> headers.
>> 
>> Reported-by: Wolfgang Walter <linux@...m.de>
>> Signed-off-by: Tom Herbert <therbert@...gle.com>
>> ---
> 
> Please Tom, add in your bug fixes something to ease backports.
> 
> Fixes: 14051f0452a2 ("gre: Use inner mac length when computing tunnel length")

Also this is extremely far reaching consequences.

The bug is in Linus's tree, so net-next is not a suitable target,
'net' is.

Also, the commit in question has been backported into -stable, so
I would need to queue it up there as well.

Please respin this against 'net', and add the Fixes: tag, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html