netdev - Re: [PATCH] stmmac: platform: fix default values of the filter bins setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54760AE9.1000006@st.com>
Date:	Wed, 26 Nov 2014 18:16:25 +0100
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Huacai Chen <chenhc@...ote.com>
Cc:	Vince Bridgers <vbridgers2013@...il.com>,
	"David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] stmmac: platform: fix default values of the filter bins
 setting

On 11/26/2014 3:38 AM, Huacai Chen wrote:
> The commit 3b57de958e2a brought the support for a different amount of
> the filter bins, but didn't update the platform driver that without
> CONFIG_OF.
>
> Fixes: 3b57de958e2a (net: stmmac: Support devicetree configs for mcast
> and ucast filter entries)
>
> Signed-off-by: Huacai Chen <chenhc@...ote.com>

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

> ---
>   .../net/ethernet/stmicro/stmmac/stmmac_platform.c  |   13 +++++++------
>   1 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index db56fa7..5b0da39 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -177,12 +177,6 @@ static int stmmac_probe_config_dt(struct platform_device *pdev,
>   	 */
>   	plat->maxmtu = JUMBO_LEN;
>
> -	/* Set default value for multicast hash bins */
> -	plat->multicast_filter_bins = HASH_TABLE_SIZE;
> -
> -	/* Set default value for unicast filter entries */
> -	plat->unicast_filter_entries = 1;
> -
>   	/*
>   	 * Currently only the properties needed on SPEAr600
>   	 * are provided. All other properties should be added
> @@ -270,6 +264,13 @@ static int stmmac_pltfr_probe(struct platform_device *pdev)
>   		return PTR_ERR(addr);
>
>   	plat_dat = dev_get_platdata(&pdev->dev);
> +
> +	/* Set default value for multicast hash bins */
> +	plat_dat->multicast_filter_bins = HASH_TABLE_SIZE;
> +
> +	/* Set default value for unicast filter entries */
> +	plat_dat->unicast_filter_entries = 1;
> +
>   	if (pdev->dev.of_node) {
>   		if (!plat_dat)
>   			plat_dat = devm_kzalloc(&pdev->dev,
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html