netdev - Re: [PATCH net-next 00/11] standardize TIPC SKB queue operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141126.123120.2063090248645805847.davem@davemloft.net>
Date:	Wed, 26 Nov 2014 12:31:20 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ying.xue@...driver.com
Cc:	jon.maloy@...csson.com, Paul.Gortmaker@...driver.com,
	erik.hugne@...csson.com, richard.alpe@...csson.com,
	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 00/11] standardize TIPC SKB queue operations

From: Ying Xue <ying.xue@...driver.com>
Date: Wed, 26 Nov 2014 11:41:44 +0800

> Now the following SKB queues are created and maintained within internal
> TIPC stack:
> 
> - link transmission queue
> - link deferred queue
> - link receive queue
> - socket outgoing packet chain
> - name table outgoing packet chain
> 
> In order to manage above queues, TIPC stack declares a sk_buff pointer
> for each queue to record its head, and directly modifies "prev" and
> "next" SKB pointers of SKB structure when inserting or deleting a SKB
> to or from the queue. As these operations are pretty complex, they
> easily involve fatal mistakes. If these sk_buff pointers are replaced
> with sk_buff_head instances as queue heads and corresponding generic
> SKB list APIs are used to manage them, the entire TIPC code would
> become quite clean and readable. But before make the change, we need
> to clean up below redundant functionalities:
> 
> - remove node subscribe infrastructure
> - remove protocol message queue
> - remove retransmission queue
> - clean up process of pushing packets in link layer 

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html