netdev - Re: [PATCH net] net-timestamp: make tcp_recvmsg call ipv6_recv_error for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141126.163747.1248122024527332519.davem@davemloft.net>
Date:	Wed, 26 Nov 2014 16:37:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	willemb@...gle.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net
Subject: Re: [PATCH net] net-timestamp: make tcp_recvmsg call
 ipv6_recv_error for AF_INET6 socks

From: Willem de Bruijn <willemb@...gle.com>
Date: Wed, 26 Nov 2014 15:03:01 -0500

> On Wed, Nov 26, 2014 at 2:53 PM, Willem de Bruijn <willemb@...gle.com> wrote:
>> From: Willem de Bruijn <willemb@...gle.com>
>>
>> TCP timestamping introduced MSG_ERRQUEUE handling for TCP sockets.
>> If the socket is of family AF_INET6, call ipv6_recv_error instead
>> of ip_recv_error.
>>
>> This change is more complex than a single branch due to the loadable
>> ipv6 module. It reuses a pre-existing indirect function call from
>> ping. The ping code is safe to call, because it is part of the core
>> ipv6 module and always present when AF_INET6 sockets are active.
> 
> I forgot to add:
> 
> Fixes: 4ed2d765 (net-timestamp: TCP timestamping)
> 
>> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied and queued up for -stable, thanks.

>> It may also be worthwhile to add WARN_ON_ONCE(sk->family == AF_INET6)
>> to ip_recv_error.

Agreed.  This kind of mistakes do happen, and these routines end up
essentially referencing garbage when it happens.

Thanks again.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html