netdev - RE: [patch net-next v3 02/17] net: make vid as a parameter for ndo_fdb_add/ndo_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 26 Nov 2014 07:35:26 +0000
From:	"Arad, Ronen" <ronen.arad@...el.com>
To:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [patch net-next v3 02/17] net: make vid as a parameter for
 ndo_fdb_add/ndo_fdb_del



>@@ -2312,7 +2313,7 @@ errout:
> int ndo_dflt_fdb_add(struct ndmsg *ndm,
> 		     struct nlattr *tb[],
> 		     struct net_device *dev,
>-		     const unsigned char *addr,
>+		     const unsigned char *addr, u16 vid,
> 		     u16 flags)
> {
> 	int err = -EINVAL;

>@@ -2409,7 +2439,7 @@ out:
> int ndo_dflt_fdb_del(struct ndmsg *ndm,
> 		     struct nlattr *tb[],
> 		     struct net_device *dev,
>-		     const unsigned char *addr)
>+		     const unsigned char *addr, u16 vid)
> {
> 	int err = -EINVAL;

What is the expected role of vid in ndo_dflt_fdb_add/ndo_dflt_fdb_del?
It is ignored in both functions. 
Will the vid be passed to dev_uc_add/dev_uc_add_excl/dev_uc_del and similar dev_mc_xxx functions?
Will the device address lists become VLAN-aware?