netdev - Re: [PATCH] stmmac: platform: Move plat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Nov 2014 15:52:20 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Huacai Chen <chenhc@...ote.com>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>
CC:	Vince Bridgers <vbridgers2013@...il.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] stmmac: platform: Move plat_dat checking earlier

Hello.

On 11/27/2014 6:14 AM, Huacai Chen wrote:

> Original code only check/alloc plat_dat for the CONFIG_OF case, this
> patch check/alloc it earlier and unconditionally to avoid kernel build
> warnings:

> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:275
> stmmac_pltfr_probe() warn: variable dereferenced before check 'plat_dat'

> Signed-off-by: Huacai Chen <chenhc@...ote.com>
> ---
>   .../net/ethernet/stmicro/stmmac/stmmac_platform.c  |   18 +++++++++---------
>   1 files changed, 9 insertions(+), 9 deletions(-)

> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index 5b0da39..d254950 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -265,6 +265,15 @@ static int stmmac_pltfr_probe(struct platform_device *pdev)
>
>   	plat_dat = dev_get_platdata(&pdev->dev);
>
> +	if (!plat_dat)
> +		plat_dat = devm_kzalloc(&pdev->dev,
> +				sizeof(struct plat_stmmacenet_data),
> +				GFP_KERNEL);

    Please start the continuation lines exactly under & on the first line.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html