netdev - Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 29 Nov 2014 00:21:48 +0100
From:	Michael Büsch <m@...s.ch>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	Nicholas Krause <xerofoify@...il.com>,
	Stefano Brivio <stefano.brivio@...imi.it>,
	Network Development <netdev@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	b43-dev <b43-dev@...ts.infradead.org>
Subject: Re: [PATCH] drivers:net:wireless: Add mutex locking for function,
 b43_op_beacon_set_time in main.c

On Fri, 28 Nov 2014 23:40:46 +0100
Rafał Miłecki <zajec5@...il.com> wrote:

> > @@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw *hw,
> >  {
> >         struct b43_wl *wl = hw_to_b43_wl(hw);
> >
> > -       /* FIXME: add locking */
> > +       mutex_lock(&wl->mutex);
> >         b43_update_templates(wl);
> > +       mutex_unlock(&wl->mutex);
> >
> >         return 0;
> >  }
> 
> Does anyone remember why this simple solution wasn't implemented
> earlier? Michael?

I think the callback used to be (is?) in atomic context.

> Nicholas: did you test it anyhow?

-- 
Michael

Content of type "application/pgp-signature" skipped