netdev - Re: [PATCH v6 28/46] vhost: make features 64 bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1417163577.5822.7@smtp.corp.redhat.com>
Date:	Fri, 28 Nov 2014 08:40:57 +0008
From:	Jason Wang <jasowang@...hat.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	linux-kernel@...r.kernel.org, thuth@...ux.vnet.ibm.com,
	kvm@...r.kernel.org, rusty@....ibm.com, netdev@...r.kernel.org,
	virtualization@...ts.linux-foundation.org, dahi@...ux.vnet.ibm.com,
	pbonzini@...hat.com, David Miller <davem@...emloft.net>
Subject: Re: [PATCH v6 28/46] vhost: make features 64 bit



On Fri, Nov 28, 2014 at 4:10 AM, Michael S. Tsirkin <mst@...hat.com> 
wrote:
> We need to use bit 32 for virtio 1.0
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>  drivers/vhost/vhost.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
> index 3eda654..c624b09 100644
> --- a/drivers/vhost/vhost.h
> +++ b/drivers/vhost/vhost.h
> @@ -106,7 +106,7 @@ struct vhost_virtqueue {
>  	/* Protected by virtqueue mutex. */
>  	struct vhost_memory *memory;
>  	void *private_data;
> -	unsigned acked_features;
> +	u64 acked_features;
>  	/* Log write descriptors */
>  	void __user *log_base;
>  	struct vhost_log *log;
> @@ -174,6 +174,6 @@ enum {
>  
>  static inline int vhost_has_feature(struct vhost_virtqueue *vq, int 
> bit)
>  {
> -	return vq->acked_features & (1 << bit);
> +	return vq->acked_features & (1ULL << bit);
>  }
>  #endif
> -- 
> MST

Reviewed-by: Jason Wang <jasowang@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html