netdev - Re: [PATCH iproute2] ip xfrm: support 64bit kernel and 32bit userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1417311202.7215.109.camel@decadent.org.uk>
Date:	Sun, 30 Nov 2014 01:33:22 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ip xfrm: support 64bit kernel and 32bit
 userspace

On Fri, 2014-11-28 at 14:58 +0800, roy.qing.li@...il.com wrote:
> From: Li RongQing <roy.qing.li@...il.com> 
> 
> The size of struct xfrm_userpolicy_info is 168 bytes for 64bit kernel, and
> 164 bytes for 32bit userspace because of the different alignment.

I think it's specific to x86 as other architectures have the same type
alignments for 32- and 64-bit variants.

> and lead to "ip xfrm" be unable to work.
> 
> add a pad in struct xfrm_userpolicy_info, and enable it by set
> KERNEL_64_USERSPACE_32 to y
[...]

This doesn't make sense.  32-bit compat needs to work like 32-bit native
- no exceptions, no workarounds in userland.  And if you really want to
work around this in userland you'll need a run-time, not compile-time,
check.

Ben.

-- 
Ben Hutchings
The world is coming to an end.	Please log off.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)