lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Nov 2014 09:54:20 -0800 From: Stephen Hemminger <stephen@...workplumber.org> To: Lino Sanfilippo <LinoSanfilippo@....de> Cc: mlindner@...vell.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] sky2: avoid pci write posting after disabling irqs On Sun, 30 Nov 2014 12:56:51 +0100 Lino Sanfilippo <LinoSanfilippo@....de> wrote: > In sky2_change_mtu setting B0_IMSK to 0 may be delayed due to PCI write posting > which could result in irqs being still active when synchronize_irq is called. > Since we are not prepared to handle any further irqs after synchronize_irq > (our resources are freed after that) force the write by a consecutive read from > the same register. > Similar situation in sky2_all_down: Here we disabled irqs by a write to B0_IMSK > but did not ensure that this write took place before synchronize_irq. Fix that > too. > > Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de> Looks correct. Acked-by: Stephen Hemminger <stephen@...workplumber.org> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists