lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Nov 2014 22:16:02 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Eric Dumazet <eric.dumazet@...il.com> CC: Paul Mackerras <paulus@...ba.org>, linux-ppp@...r.kernel.org, netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: Re: [PATCH 3/3] net-PPP: Delete an unnecessary assignment > I have no idea why its a patch on its own, and why state->arc4 gets > special treatment while state->sha1 does not. I did not fiddle with the data structure element "sha1" because I assumed that it might be still relevant for the call of a function like crypto_free_blkcipher(). > This definitely belongs to the previous patch, refactoring error > handling in mppe_alloc() I have got different preferences for change distribution over several patches here. I find it safer to tackle an assignment clean-up after adjustments for jump labels. > Also, it seems your patches do not fix bugs, so so you need to target > net-next tree, as explained in Documentation/networking/netdev-FAQ.txt Do you want that I resend my update suggestion? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists