netdev - Re: [PATCH net-next] test: bpf: expand DIV_KX to DIV_MOD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMEtUuwPkvCP1=nc3V+grc_Gp-7JG8GZLpJtDEeMr5mR-T-w1A@mail.gmail.com>
Date:	Mon, 1 Dec 2014 09:44:55 -0800
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Denis Kirjanov <kda@...ux-powerpc.org>,
	Daniel Borkmann <dborkman@...hat.com>
Cc:	Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] test: bpf: expand DIV_KX to DIV_MOD_KX

On Mon, Dec 1, 2014 at 2:12 AM, Denis Kirjanov <kda@...ux-powerpc.org> wrote:
> Expand DIV_KX to use BPF_MOD operation in the
> DIV_KX bpf 'classic' test.
>
> CC: Alexei Starovoitov <ast@...mgrid.com>
> Signed-off-by: Denis Kirjanov <kda@...ux-powerpc.org>

Increases test coverage. Makes sense. Thanks
Acked-by: Alexei Starovoitov <ast@...mgrid.com>

> ---
>  lib/test_bpf.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/lib/test_bpf.c b/lib/test_bpf.c
> index 3f167d2..80d78c5 100644
> --- a/lib/test_bpf.c
> +++ b/lib/test_bpf.c
> @@ -124,7 +124,7 @@ static struct bpf_test tests[] = {
>                 { { 0, 0xfffffffd } }
>         },
>         {
> -               "DIV_KX",
> +               "DIV_MOD_KX",
>                 .u.insns = {
>                         BPF_STMT(BPF_LD | BPF_IMM, 8),
>                         BPF_STMT(BPF_ALU | BPF_DIV | BPF_K, 2),
> @@ -134,12 +134,18 @@ static struct bpf_test tests[] = {
>                         BPF_STMT(BPF_MISC | BPF_TAX, 0),
>                         BPF_STMT(BPF_LD | BPF_IMM, 0xffffffff),
>                         BPF_STMT(BPF_ALU | BPF_DIV | BPF_K, 0x70000000),
> +                       BPF_STMT(BPF_MISC | BPF_TAX, 0),
> +                       BPF_STMT(BPF_LD | BPF_IMM, 0xffffffff),
> +                       BPF_STMT(BPF_ALU | BPF_MOD | BPF_X, 0),
> +                       BPF_STMT(BPF_MISC | BPF_TAX, 0),
> +                       BPF_STMT(BPF_LD | BPF_IMM, 0xffffffff),
> +                       BPF_STMT(BPF_ALU | BPF_MOD | BPF_K, 0x70000000),
>                         BPF_STMT(BPF_ALU | BPF_ADD | BPF_X, 0),
>                         BPF_STMT(BPF_RET | BPF_A, 0)
>                 },
>                 CLASSIC | FLAG_NO_DATA,
>                 { },
> -               { { 0, 0x40000001 } }
> +               { { 0, 0x20000000 } }
>         },
>         {
>                 "AND_OR_LSH_K",
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html