netdev - Re: [PATCH net-next V3] tun/macvtap: use consume_skb() instead of kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1417412115.7521.2@smtp.corp.redhat.com>
Date:	Mon, 01 Dec 2014 05:43:15 +0008
From:	Jason Wang <jasowang@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	mst@...hat.com, eric.dumazet@...il.com
Subject: Re: [PATCH net-next V3] tun/macvtap: use consume_skb() instead of
 kfree_skb() when needed



On Sun, Nov 30, 2014 at 1:03 PM, David Miller <davem@...emloft.net> 
wrote:
> From: Jason Wang <jasowang@...hat.com>
> Date: Thu, 27 Nov 2014 14:36:06 +0800
> 
>>  To be more friendly with drop monitor, we should only call 
>> kfree_skb() when
>>  the packets were dropped and use consume_skb() in other cases.
>>  
>>  Cc: Eric Dumazet <eric.dumazet@...il.com>
>>  Signed-off-by: Jason Wang <jasowang@...hat.com>
>>  ---
>>  Changes from V2:
>>  - use unlikely() when necessary
>>  Changes from V1:
>>  - check the return value of tun/macvtap_put_user()
> 
> This does not apply cleanly to net-next and will thus need to
> be respun, thanks.

Will post V3.

Thanks

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html