netdev - Re: [PATCH] mips: bpf: Fix broken BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJe8K16q6T7z2C3SOhD-be5oM1AMfxtkv6BA2ruEFvYAbkuSA@mail.gmail.com>
Date:	Mon, 1 Dec 2014 17:55:38 +0400
From:	Denis Kirjanov <kda@...ux-powerpc.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	netdev@...r.kernel.org, markos.chandras@...tec.com
Subject: Re: [PATCH] mips: bpf: Fix broken BPF_MOD

On 12/1/14, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote:
> Hello.
>
> On 12/1/2014 12:57 PM, Denis Kirjanov wrote:
>
>     You should CC the 'linux-mips' ML.
>
>> Remove optimize_div() from BPF_MOD | BPF_K case
>> since we don't know the dividend and fix the
>> emit_mod() by reading the mod operation result from HI register
>
>     Isn't this 2 unrelated fixes? They should be in 2 patches, not a single
>
> one in that case.
>

They do fix the BPD_MOD _single_ case.  I don't think that it's a good
reason here to split  the fin in 2 patches

>> Signed-off-by: Denis Kirjanov <kda@...ux-powerpc.org>
>> ---
>>   arch/mips/net/bpf_jit.c |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> WBR, Sergei
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html