netdev - Re: [PATCH net v1 1/2] amd-xgbe: Do not clear interrupt indicator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <547F1DEE.2070808@amd.com>
Date:	Wed, 3 Dec 2014 08:27:58 -0600
From:	Tom Lendacky <thomas.lendacky@....com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	<netdev@...r.kernel.org>
CC:	David Miller <davem@...emloft.net>
Subject: Re: [PATCH net v1 1/2] amd-xgbe: Do not clear interrupt indicator

On 12/03/2014 05:34 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 12/3/2014 3:16 AM, Tom Lendacky wrote:
>
>> The interrupt value within the xgbe_ring_data structure is used as an
>> indicator of which Rx descriptor should have the INTE bit set to
>> generate an interrupt when that Rx descriptor is used.  This bit was
>> mistakenly cleared in the xgbe_unmap_rdata function, effectively
>
>     Not xgbe_unmap_skb() (as seems to follow from the patch)?

Yup, I'm mixing up my versions between net-next and net. I'll send
an updated version with a more appropriate comment.

Thanks,
Tom

>
>> nullifying the ethtool rx-frames support.
>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@....com>
>> ---
>>   drivers/net/ethernet/amd/xgbe/xgbe-desc.c |    1 -
>>   1 file changed, 1 deletion(-)
>
>> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
>> b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
>> index 6fc5da0..43b7d2e 100644
>> --- a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
>> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
>> @@ -356,7 +356,6 @@ static void xgbe_unmap_skb(struct xgbe_prv_data
>> *pdata,
>>
>>       rdata->tso_header = 0;
>>       rdata->len = 0;
>> -    rdata->interrupt = 0;
>>       rdata->mapped_as_page = 0;
>>
>>       if (rdata->state_saved) {
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html