netdev - [PATCH v2 0/6] net: Add helper for padding short Ethernet frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Dec 2014 08:17:26 -0800
From:	Alexander Duyck <alexander.h.duyck@...hat.com>
To:	netdev@...r.kernel.org
Cc:	davem@...emloft.net
Subject: [PATCH v2 0/6] net: Add helper for padding short Ethernet frames

This patch series adds a pair of helpers to pad short Ethernet frames.  The
general idea is to clean up a number of code paths that were all writing
their own versions of the same or similar function.

An added advantage is that this will help to discourage introducing new
bugs as in at least one case I found the skb->len had been updated, but the
tail pointer update was overlooked.

v2: Added skb_put_padto for cases where length is not ETH_ZLEN
    Updated intel drivers and emulex driver to use skb_put_padto
    Updated eth_skb_pad to use skb_put_padto

---

Alexander Duyck (6):
      net: Add functions for handling padding frame and adding to length
      ethernet/intel: Use eth_skb_pad and skb_put_padto helpers
      emulex: Use skb_put_padto instead of skb_padto() and skb->len assignment
      niu: Use eth_skb_pad helper
      myri10ge: use eth_skb_pad helper
      r8169: Use eth_skb_pad function


 drivers/net/ethernet/emulex/benet/be_main.c       |    3 +--
 drivers/net/ethernet/intel/e1000/e1000_main.c     |    8 ++-----
 drivers/net/ethernet/intel/e1000e/netdev.c        |    8 ++-----
 drivers/net/ethernet/intel/fm10k/fm10k_main.c     |   11 +++-------
 drivers/net/ethernet/intel/i40e/i40e_txrx.c       |    8 ++-----
 drivers/net/ethernet/intel/igb/igb_main.c         |   19 ++++-------------
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c     |   19 ++++-------------
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |   11 +++-------
 drivers/net/ethernet/myricom/myri10ge/myri10ge.c  |   15 ++++---------
 drivers/net/ethernet/realtek/r8169.c              |   12 ++---------
 drivers/net/ethernet/sun/niu.c                    |    9 ++------
 include/linux/etherdevice.h                       |   12 +++++++++++
 include/linux/skbuff.h                            |   24 ++++++++++++++++++++-
 13 files changed, 67 insertions(+), 92 deletions(-)

--
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html