netdev - Re: [PATCH iproute2] ip route: don't assume default route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 3 Dec 2014 09:17:02 -0800
From:	Stephen Hemminger <shemming@...cade.com>
To:	Pavel Šimerda <psimerda@...hat.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] ip route: don't assume default route

On Tue, 2 Dec 2014 17:45:10 +0100
=?UTF-8?q?Pavel=20=C5=A0imerda?=  <psimerda@...hat.com> wrote:

> Just print the help when "ip route del" is called without any other
> arguments.
> 
> Resolves:
> 
>  * https://bugzilla.redhat.com/show_bug.cgi?id=997965
> 
> Signed-off-by: Pavel Šimerda <psimerda@...hat.com>
> ---
>  ip/iproute.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/ip/iproute.c b/ip/iproute.c
> index d77b1e3..c171f29 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -975,6 +975,9 @@ static int iproute_modify(int cmd, unsigned flags, int argc, char **argv)
>  		argc--; argv++;
>  	}
>  
> +	if (!dst_ok)
> +		usage();
> +
>  	if (d || nhs_ok)  {
>  		int idx;
>  

Good catch. Applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html