netdev - Re: [PATCH net-next v3] rtnetlink: delay RTM_DELLINK notification until after ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF2d9jh2-iFO5VA6=O=L=BjQ=WgtBgviV=BvJH5QHZKuydQgvg@mail.gmail.com>
Date:	Wed, 3 Dec 2014 11:08:43 -0800
From:	Mahesh Bandewar <maheshb@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Subject: Re: [PATCH net-next v3] rtnetlink: delay RTM_DELLINK notification
 until after ndo_uninit()

On Tue, Dec 2, 2014 at 11:39 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Tue, 2014-12-02 at 23:24 -0800, Mahesh Bandewar wrote:
>
>> +EXPORT_SYMBOL(rtmsg_ifinfo_build_skb);
>> +
>> +void rtmsg_ifinfo_send(struct sk_buff *skb, struct net_device *dev, gfp_t flags)
>> +{
>> +     struct net *net = dev_net(dev);
>> +
>> +     rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, flags);
>> +}
>> +EXPORT_SYMBOL(rtmsg_ifinfo_send);
>> +
>> +void rtmsg_ifinfo(int type, struct net_device *dev, unsigned int change,
>> +               gfp_t flags)
>> +{
>> +     struct sk_buff *skb;
>> +
>> +     skb = rtmsg_ifinfo_build_skb(type, dev, change, flags);
>> +     if (skb)
>> +             rtmsg_ifinfo_send(skb, dev, flags);
>>  }
>>  EXPORT_SYMBOL(rtmsg_ifinfo);
>
> One last point :
>
> Only rtmsg_ifinfo() needs the EXPORT_SYMBOL(...)
>
> rtmsg_ifinfo_build_skb() and rtmsg_ifinfo_send() are used from core networking stack,
> not a module.
>
Thanks Eric. If we ever need that in a module in the future, we can
add that later. Will remove them.
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html