netdev - Re: [PATCH v2 2/6] ethernet/intel: Use eth_skb_pad and skb_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Dec 2014 11:25:23 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Alexander Duyck <alexander.h.duyck@...hat.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v2 2/6] ethernet/intel: Use eth_skb_pad and
 skb_put_padto helpers

On Wed, 2014-12-03 at 08:17 -0800, Alexander Duyck wrote:
> Update the Intel Ethernet drivers to use eth_skb_pad() and
> skb_put_padto
> instead of doing their own implementations of the function.
> 
> Also this cleans up two other spots where skb_pad was called but the
> length
> and tail pointers were being manipulated directly instead of just
> having
> the padding length added via __skb_put.
> 
> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>
> ---
>  drivers/net/ethernet/intel/e1000/e1000_main.c     |    8 ++------
>  drivers/net/ethernet/intel/e1000e/netdev.c        |    8 ++------
>  drivers/net/ethernet/intel/fm10k/fm10k_main.c     |   11 +++--------
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c       |    8 ++------
>  drivers/net/ethernet/intel/igb/igb_main.c         |   19
> +++++--------------
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c     |   19
> +++++--------------
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |   11 +++--------
>  7 files changed, 22 insertions(+), 62 deletions(-)

Since this is a part of a series, no need to break it up, by having me
only pull in this one patch.

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)