netdev - Re: [PATCH net-next v4] rtnetlink: delay RTM_DELLINK notification until after ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141203222510.GB8822@casper.infradead.org>
Date:	Wed, 3 Dec 2014 22:25:10 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	Mahesh Bandewar <maheshb@...gle.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Subject: Re: [PATCH net-next v4] rtnetlink: delay RTM_DELLINK notification
 until after ndo_uninit()

On 12/03/14 at 01:46pm, Mahesh Bandewar wrote:
> The commit 56bfa7ee7c ("unregister_netdevice : move RTM_DELLINK to
> until after ndo_uninit") tried to do this ealier but while doing so
> it created a problem. Unfortunately the delayed rtmsg_ifinfo() also
> delayed call to fill_info(). So this translated into asking driver
> to remove private state and then query it's private state. This
> could have catastropic consequences.
> 
[...]
> 
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
> Reported-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Roopa Prabhu <roopa@...ulusnetworks.com>
> Cc: David S. Miller <davem@...emloft.net>

LGTM, thanks!

Acked-by: Thomas Graf <tgraf@...g.ch>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html