netdev - Re: [patch iproute2 0/6] iproute2: add changes for switchdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141204160444.GF1861@nanopsycho.orion>
Date:	Thu, 4 Dec 2014 17:04:44 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, nhorman@...driver.com,
	andy@...yhouse.net, tgraf@...g.ch, dborkman@...hat.com,
	ogerlitz@...lanox.com, jesse@...ira.com, pshelar@...ira.com,
	azhou@...ira.com, ben@...adent.org.uk, stephen@...workplumber.org,
	jeffrey.t.kirsher@...el.com, vyasevic@...hat.com,
	xiyou.wangcong@...il.com, john.r.fastabend@...el.com,
	edumazet@...gle.com, jhs@...atatu.com, sfeldma@...il.com,
	f.fainelli@...il.com, linville@...driver.com, jasowang@...hat.com,
	ebiederm@...ssion.com, nicolas.dichtel@...nd.com,
	ryazanov.s.a@...il.com, buytenh@...tstofly.org,
	aviadr@...lanox.com, nbd@...nwrt.org, alexei.starovoitov@...il.com,
	Neil.Jerram@...aswitch.com, ronye@...lanox.com,
	simon.horman@...ronome.com, alexander.h.duyck@...hat.com,
	john.ronciak@...el.com, mleitner@...hat.com, shrijeet@...il.com,
	gospo@...ulusnetworks.com, bcrl@...ck.org, hemal@...adcom.com
Subject: Re: [patch iproute2 0/6] iproute2: add changes for switchdev

Thu, Dec 04, 2014 at 03:45:44PM CET, roopa@...ulusnetworks.com wrote:
>On 12/4/14, 6:34 AM, Jiri Pirko wrote:
>>Thu, Dec 04, 2014 at 03:26:50PM CET, roopa@...ulusnetworks.com wrote:
>>>On 12/4/14, 12:57 AM, Jiri Pirko wrote:
>>>>Jiri Pirko (1):
>>>>   iproute2: ipa: show switch id
>>>>
>>>>Scott Feldman (5):
>>>>   bridge/fdb: fix statistics output spacing
>>>>   bridge/fdb: add flag/indication for FDB entry synced from offload
>>>>     device
>>>>   bridge/link: add new offload hwmode swdev
>>>Ack to most patches but nack on this one. The todo list still has a note to
>>>revist the flag to indicate switchdev offloads.
>>>Exposing this to userspace does not help that.
>>Hmm, note that this is already exposed to userspace, this patchset is
>>for iproute2 (userspace tool).
>hmmm, all feedback on the switchdev patches seemed to indicate we can change
>this later.
> I don't see swdev mode being used in the kernel anywhere today.

Well, it is, in rocker:
$ git grep BRIDGE_MODE_SWDEV
drivers/net/ethernet/rocker/rocker.c:                   if (mode != BRIDGE_MODE_SWDEV)
drivers/net/ethernet/rocker/rocker.c:   u16 mode = BRIDGE_MODE_SWDEV;
include/uapi/linux/if_bridge.h:#define BRIDGE_MODE_SWDEV        2       /* Full switch device offload */

>I will send a patch to remove it. Its still in net-next and so can be changed
>?.
>I was going to resend my patch to introduce a common offload flag for all
>link objects.
>It would be nice if all of them had a consistent flag to indicate hw offload
>and iproute2 could display the same flag for all.
>Including bonds and vxlan's.

I do not understand the connection with BRIDGE_MODE_SWDEV. We discussed
this already. BRIDGE_MODE_SWDEV is a bridge mode, similar to for example
BRIDGE_MODE_VEPA and makes perfect sense to have it.

How vxlan and bonds come into the mixture, that is a puzzler for me.
Maybe I have to see patches.

>
>>
>>>>   link: add missing IFLA_BRPORT_PROXYARP
>>>>   bridge/link: add learning_sync policy flag
>>>>
>>>>  bridge/fdb.c              |  4 +++-
>>>>  bridge/link.c             | 17 +++++++++++++++--
>>>>  include/linux/if_bridge.h |  1 +
>>>>  include/linux/if_link.h   |  3 +++
>>>>  include/linux/neighbour.h |  1 +
>>>>  ip/ipaddress.c            |  8 ++++++++
>>>>  man/man8/bridge.8         | 19 ++++++++++++++-----
>>>>  7 files changed, 45 insertions(+), 8 deletions(-)
>>>>
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html