netdev - [PATCH] net: ethernet: rocker: Add select to CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54809BA5.7030901@rupran.de>
Date:	Thu, 04 Dec 2014 18:36:37 +0100
From:	Andreas Ruprecht <mail@...ran.de>
To:	Jim Davis <jim.epost@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next <linux-next@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>, jiri@...nulli.us,
	sfeldma@...il.com, netdev <netdev@...r.kernel.org>
Subject: [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig

On 04.12.2014 17:34, Jim Davis wrote:
> Building with the attached random configuration file,
> 
> drivers/built-in.o: In function `rocker_port_fdb_learn_work':
> /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3014: undefined
> reference to `br_fdb_external_learn_del'
> /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3016: undefined
> reference to `br_fdb_external_learn_add'
> 

Hi,

the problem here is that CONFIG_BRIDGE is set to 'm' (leading to
inclusion of the two functions above in the kernel module) while
CONFIG_ROCKER is set to 'y', requiring the functions at link time.

Is the attached patch sufficient to fix this?

Regards,

Andreas

View attachment "0001-net-ethernet-rocker-Add-select-to-CONFIG_BRIDGE-in-K.patch" of type "text/x-patch" (1335 bytes)