netdev - Re: [PATCH][net-next] net: avoid to call skb_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1417789870.15618.1.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 05 Dec 2014 06:31:10 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	roy.qing.li@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH][net-next] net: avoid to call skb_queue_len again

On Fri, 2014-12-05 at 17:06 +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/5/2014 12:49 PM, roy.qing.li@...il.com wrote:
> 
> > From: Li RongQing <roy.qing.li@...il.com>
> 
> > the queue length of sd->input_pkt_queue has been putted into qlen,
> 
>     s/putted/put/, it's irregular verb.
> 
> > and impossible to change, since hold the lock
> 
>     I can't parse that. Who holds the lock?

This thread/cpu holds the lock to manipulate input_pkt_queue.

Otherwise, the following would break horribly....

__skb_queue_tail(&sd->input_pkt_queue, skb);



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html