netdev - Re: [patch net-next 1/2] net: sched: cls_basic: fix error path in basic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1417795431.15618.6.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 05 Dec 2014 08:03:51 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
	davem@...emloft.net, jhs@...atatu.com
Subject: Re: [patch net-next 1/2] net: sched: cls_basic: fix error path in
 basic_change()

On Fri, 2014-12-05 at 07:29 -0800, John Fastabend wrote:
> On 12/05/2014 06:50 AM, Jiri Pirko wrote:
> > Signed-off-by: Jiri Pirko <jiri@...nulli.us>
> > ---
> >   net/sched/cls_basic.c | 5 ++---
> >   1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
> > index 7cf0a62..5aed341 100644
> > --- a/net/sched/cls_basic.c
> > +++ b/net/sched/cls_basic.c
> > @@ -178,10 +178,9 @@ static int basic_change(struct net *net, struct sk_buff *in_skb,
> >   			return -EINVAL;
> >   	}
> >
> > -	err = -ENOBUFS;
> >   	fnew = kzalloc(sizeof(*fnew), GFP_KERNEL);
> > -	if (fnew == NULL)
> > -		goto errout;
> > +	if (!fnew)
> > +		return -ENOBUFS;
> >
> >   	tcf_exts_init(&fnew->exts, TCA_BASIC_ACT, TCA_BASIC_POLICE);
> >   	err = -EINVAL;
> >
> 
> Nice catch, thanks!
> 
> Reviewed-by: John Fastabend <john.r.fastabend@...el.com>

Sorry, but this looks a cosmetic change, right ?

If it is a fix, we'd like a 'Fixes: ...' tag.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html