netdev - Re: [PATCH iproute2 REGRESSIONS v2] ss: Fix layout/output issues introduced by regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141205170641.GA23226@angus-think.wlc.globallogic.com>
Date:	Fri, 5 Dec 2014 19:06:42 +0200
From:	vadim4j@...il.com
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 REGRESSIONS v2] ss: Fix layout/output issues
 introduced by regression

 [...]
> >@@ -2912,11 +2910,12 @@ static void netlink_show_one(struct filter *f,
> >  		printf("%-*s ", state_width, "UNCONN");
> >  	printf("%-6d %-6d ", rq, wq);
> >
> >-	if (resolve_services)
> >-	{
> >+	if (resolve_services) {
> >  		printf("%*s:", addr_width, nl_proto_n2a(prot, prot_name,
> >  					sizeof(prot_name)));
> >-	}
> >+	} else
> >+		printf("%*d:", addr_width, prot);
> >+
> 
>    Extra empty line hardly needed here. And if iproute2 follows the Linux
> kernel style, {} should be used in all arms of the *if* statement (since
> it's used in one case).
> 
> >
> >  	if (pid == -1) {
> >  		printf("%-*s ", serv_width, "*");
> 
> WBR, Sergei
> 

You mean change to this ?

	if (resolve_services) {
 		printf("%*s:", addr_width, nl_proto_n2a(prot, prot_name,
 					sizeof(prot_name)));
	} else {
		printf("%*d:", addr_width, prot);
        }

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html