netdev - Re: [PATCH 2/3] bridge: offload bridge port attributes to switch asic if feature flag set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141205073840.GA1866@nanopsycho.orion>
Date:	Fri, 5 Dec 2014 08:38:40 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	roopa@...ulusnetworks.com
Cc:	sfeldma@...il.com, jhs@...atatu.com, bcrl@...ck.org, tgraf@...g.ch,
	john.fastabend@...il.com, stephen@...workplumber.org,
	linville@...driver.com, nhorman@...driver.com,
	nicolas.dichtel@...nd.com, vyasevic@...hat.com,
	f.fainelli@...il.com, buytenh@...tstofly.org, aviadr@...lanox.com,
	netdev@...r.kernel.org, davem@...emloft.net,
	shm@...ulusnetworks.com, gospo@...ulusnetworks.com
Subject: Re: [PATCH 2/3] bridge: offload bridge port attributes to switch
 asic if feature flag set

Fri, Dec 05, 2014 at 03:26:40AM CET, roopa@...ulusnetworks.com wrote:
>From: Roopa Prabhu <roopa@...ulusnetworks.com>
>
>This allows offloading to switch asic without having the user to set
>any flag. And this is done in the bridge driver to rollback kernel settings
>on hw offload failure if required in the future.
>
>With this, it also makes sure a notification goes out only after the
>attributes are set both in the kernel and hw.
>---
> net/bridge/br_netlink.c |   27 ++++++++++++++++++++++++++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
>
>diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
>index 9f5eb55..ce173f0 100644
>--- a/net/bridge/br_netlink.c
>+++ b/net/bridge/br_netlink.c
>@@ -407,9 +407,21 @@ int br_setlink(struct net_device *dev, struct nlmsghdr *nlh)
> 				afspec, RTM_SETLINK);
> 	}
> 
>+	if ((dev->features & NETIF_F_HW_SWITCH_OFFLOAD) &&
>+			dev->netdev_ops->ndo_bridge_setlink) {
>+		int ret = dev->netdev_ops->ndo_bridge_setlink(dev, nlh);

	This (and I suspect other patches as well) has many issues which
	are pointed out by scripts/checkpatch.pl sctipts. For example
	here, there should be an empty line. Please run your patches by
	this script before you send them.

>+		if (ret && ret != -EOPNOTSUPP) {
>+			/* XXX Fix this in the future to rollback
>+			 * kernel settings and return error
>+			 */
>+			br_warn(p->br, "error offloading bridge attributes " 
>+					"on port %u(%s)\n", (unsigned int) p->port_no,
>+					p->dev->name);
>+		}
>+	}
>+
> 	if (err == 0)
> 		br_ifinfo_notify(RTM_NEWLINK, p);
>-
> out:
> 	return err;
> }
>@@ -433,6 +445,19 @@ int br_dellink(struct net_device *dev, struct nlmsghdr *nlh)
> 	err = br_afspec((struct net_bridge *)netdev_priv(dev), p,
> 			afspec, RTM_DELLINK);
> 
>+	if (dev->features & NETIF_F_HW_SWITCH_OFFLOAD
>+			&& dev->netdev_ops->ndo_bridge_setlink) {
>+		int ret = dev->netdev_ops->ndo_bridge_dellink(dev, nlh);

	c&p issue, there should be check for dellink here.

>+		if (ret && ret != -EOPNOTSUPP) {
>+			/* XXX Fix this in the future to rollback
>+			 * kernel settings and return error
>+			 */
>+			br_warn(p->br, "error offloading bridge attributes " 
>+					"on port %u(%s)\n", (unsigned int) p->port_no,
>+					p->dev->name);
>+		}
>+	}
>+


	I agree with Scott that this code should be moved to rtnetlink.c

> 	return err;
> }
> static int br_validate(struct nlattr *tb[], struct nlattr *data[])
>-- 
>1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html