netdev - Re: [PATCH] net: ethernet: rocker: Add select to CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54816C93.2020009@rupran.de>
Date:	Fri, 05 Dec 2014 09:28:03 +0100
From:	Andreas Ruprecht <mail@...ran.de>
To:	David Miller <davem@...emloft.net>
CC:	jim.epost@...il.com, sfr@...b.auug.org.au,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	jiri@...nulli.us, sfeldma@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in
 Kconfig

> On 05.12.2014 05:24, David Miller wrote:
> Do not use select, please.
> 
> You can only use select on leaf node Kconfig symbols, ie. those
> which do not have any dependencies whatsoever.
> 
> Select does not recursively walk down the dependency chain turning
> things on for you when you say "select X".
> 

Okay, sure, my bad for not looking that up properly.

If we change this into a "depends on", this should not be a problem,
right? If CONFIG_BRIDGE is selected as 'm', then CONFIG_ROCKER can only
be 'n' or 'm', if CONFIG_BRIDGE is set to 'y', it can be 'n', 'm' or 'y'.

This also means that the prompt associated with CONFIG_ROCKER will only
show up in menuconfig when CONFIG_BRIDGE has been enabled (either 'm' or
'y').

I've attached an updated patch.

View attachment "0001-net-ethernet-rocker-Add-dependency-to-CONFIG_BRIDGE-.patch" of type "text/x-patch" (1400 bytes)