netdev - Re: [net-next 04/14] ixgbe: remove CIAA/D register reads from bad VF check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1417841892.2399.2.camel@jtkirshe-mobl>
Date:	Fri, 05 Dec 2014 20:58:12 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	emil.s.tantilov@...el.com, netdev@...r.kernel.org,
	nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com,
	alex.williamson@...hat.com
Subject: Re: [net-next 04/14] ixgbe: remove CIAA/D register reads from bad
 VF check

On Fri, 2014-12-05 at 20:49 -0800, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Fri,  5 Dec 2014 09:52:43 -0800
> 
> > From: Emil Tantilov <emil.s.tantilov@...el.com>
> > 
> > Accessing the CIAA/D register can block access to the PCI config space.
> > 
> > This patch removes the read/write operations to the CIAA/D registers
> > and makes use of standard kernel functions for accessing the PCI config
> > space.
> > 
> > In addition it moves ixgbevf_check_for_bad_vf() into the watchdog subtask
> > which reduces the frequency of the checks.
> > 
> > CC: Alex Williamson <alex.williamson@...hat.com>
> > Reported-by: Alex Williamson <alex.williamson@...hat.com>
> > Signed-off-by: Emil Tantilov <emil.s.tantilov@...el.com>
> > Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> Alex Willaimson stated that he'd like to see this for -stable, but I'm warning
> right now that a change not appropriate for 'net' is not approperiate for
> '-stable' either.

Agreed, only reason I did not send this to net (along with the other
fixes by Emil) was that we are at -rc7 and do not consider these
"critical" to try and squeeze in before the release.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)