netdev - Re: [PATCH] pxa168: close race between napi and irq activation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141205.213402.629192734867363303.davem@davemloft.net>
Date:	Fri, 05 Dec 2014 21:34:02 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	LinoSanfilippo@....de
Cc:	arnd@...db.de, paul.gortmaker@...driver.com,
	w-lkml@...enslange-mailadresse.de, f.fainelli@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pxa168: close race between napi and irq activation

From: Lino Sanfilippo <LinoSanfilippo@....de>
Date: Sun, 30 Nov 2014 11:49:36 +0100

> In pxa168_eth_open() the irqs are enabled before napi. This opens a tiny time
> window in which the irq handler is processed, disables irqs but then is not able
> to schedule the not yet activated napi, leaving irqs disabled forever (since
> irqs are reenabled in napi poll function).
> Fix this race by activating napi before irqs are activated.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html