lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 7 Dec 2014 12:44:42 -0800 From: Jeremiah Mahler <jmmahler@...il.com> To: Julia Lawall <Julia.Lawall@...6.fr> Cc: kernel-janitors@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 12/20] hp100: fix misspelling of current function in string Julia, On Sun, Dec 07, 2014 at 08:20:54PM +0100, Julia Lawall wrote: > Replace a misspelled function name by %s and then __func__. > > This was done using Coccinelle, including the use of Levenshtein distance, > as proposed by Rasmus Villemoes. > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> > > --- > The semantic patch is difficult to summarize, but is available in the cover > letter of this patch series. > > drivers/net/ethernet/hp/hp100.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/hp/hp100.c b/drivers/net/ethernet/hp/hp100.c > index 76a6e0c..ae6e30d 100644 > --- a/drivers/net/ethernet/hp/hp100.c > +++ b/drivers/net/ethernet/hp/hp100.c > @@ -490,7 +490,8 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus, > > eid = hp100_read_id(ioaddr); > if (eid == NULL) { /* bad checksum? */ > - printk(KERN_WARNING "hp100_probe: bad ID checksum at base port 0x%x\n", ioaddr); > + printk(KERN_WARNING "%s: bad ID checksum at base port 0x%x\n", > + __func__, ioaddr); More printk statements that can be change to pr_warn() to fix the checkpatch warning. > goto out2; > } > > @@ -498,7 +499,9 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus, > for (i = uc = 0; i < 7; i++) > uc += hp100_inb(LAN_ADDR + i); > if (uc != 0xff) { > - printk(KERN_WARNING "hp100_probe: bad lan address checksum at port 0x%x)\n", ioaddr); > + printk(KERN_WARNING > + "%s: bad lan address checksum at port 0x%x)\n", > + __func__, ioaddr); And here too. > err = -EIO; > goto out2; > } > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists