netdev - RE: [PATCH net-next V1] net/mlx4_en: ethtool force speed when asking for autoneg=off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CA04B67@AcuExch.aculab.com>
Date:	Mon, 8 Dec 2014 10:56:30 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Amir Vadai' <amirv@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	"Saeed Mahameed" <saeedm@...lanox.com>
Subject: RE: [PATCH net-next V1] net/mlx4_en: ethtool force speed when
 asking for autoneg=off

From: Amir Vadai
> From: Saeed Mahameed <saeedm@...lanox.com>
> 
> Use cmd->autoneg == AUTONEG_DISABLE as a user hint to force specific speed.
> We don't want to rely on ethtool to calculate advertised link modes when
> forcing specific speed, a user can request a specific speed and specify
> "autoneg off" in ethtool command to give a hint for forcing this speed.

I'm not 100% sure what you are trying to achieve?

By far the safest way to 'force' a specific speed is to set the
advertised modes to contain only the desired speed.
Doing anything else on links that are capable of auto-negotiation
is a complete recipe for disaster.

Even if you fix the operating mode of the PHY and MAC you almost
certainly want to advertise that mode to the remote system.

Yes, I know this is made all the more complicated by 10/100M autodetect.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html