netdev - Re: [PATCH 1/4 net-next] net: bcmgenet: bcmgenet_init_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141209.134325.414522197018623848.davem@davemloft.net>
Date:	Tue, 09 Dec 2014 13:43:25 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pgynther@...gle.com
Cc:	netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH 1/4 net-next] net: bcmgenet: bcmgenet_init_tx_ring()
 cleanup

From: Petri Gynther <pgynther@...gle.com>
Date: Wed,  3 Dec 2014 20:11:31 -0800 (PST)

> -/* Initialize all house-keeping variables for a TX ring, along
> - * with corresponding hardware registers
> +/*
> + * Initialize a Tx ring along with corresponding hardware registers.
>   */

You are breaking the coding style of this comment.

In the Linux networking, the proper comment layout is:

	/* Like
	 * this.
	 */

not:

	/*
	 * Like this.
	 */

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html