netdev - Re: [PATCH] net: tulip: Remove private "strncmp"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141209.134547.1067254735927828157.davem@davemloft.net>
Date:	Tue, 09 Dec 2014 13:45:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	linux@...musvillemoes.dk
Cc:	grundler@...isc-linux.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: tulip: Remove private "strncmp"

From: Rasmus Villemoes <linux@...musvillemoes.dk>
Date: Thu,  4 Dec 2014 11:30:40 +0100

> The comment says that the built-in strncmp didn't work. That is not
> surprising, as apparently "str" semantics are not really what is
> wanted (hint: de4x5_strncmp only stops when two different bytes are
> encountered or the end is reached; not if either byte happens to be
> 0). de4x5_strncmp is actually a memcmp (except for the signature and
> that bytes are not necessarily treated as unsigned char); since only
> the boolean value of the result is used we can just replace
> de4x5_strncmp with memcmp.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html