netdev - Re: [PATCH net-next 06/10] net/mlx4: Add mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141209.144210.1356501987854068706.davem@davemloft.net>
Date:	Tue, 09 Dec 2014 14:42:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	netdev@...r.kernel.org, matanb@...lanox.com, amirv@...lanox.com,
	talal@...lanox.com, jackm@....mellanox.co.il
Subject: Re: [PATCH net-next 06/10] net/mlx4: Add mlx4_bitmap zone allocator

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Thu,  4 Dec 2014 15:13:51 +0200

> +static u32 mlx4_bitmap_max(struct mlx4_bitmap *bitmap)
> +{
> +	return bitmap->max;
> +}
> +
> +static u32 mlx4_bitmap_effective_len(struct mlx4_bitmap *bitmap)
> +{
> +	return bitmap->effective_len;
> +}

Using functions for just accessing structure members is excessive, please
just open code this.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html