netdev - Re: [PATCH 1/1] net: dsa: Fix of kernel panic in case of missing PHY.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54875173.3070504@cogentembedded.com>
Date:	Tue, 09 Dec 2014 22:45:55 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Andrey Volkov <andrey.volkov@...vision.fr>, netdev@...r.kernel.org
CC:	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH 1/1] net: dsa: Fix of kernel panic in case of missing
 PHY.

Hello.

On 12/09/2014 08:31 PM, Andrey Volkov wrote:

> Fix of kernel panic in case of missing PHY.

> Signed-off-by: Andrey Volkov <andrey.volkov@...vision.fr>
> ---
>   net/dsa/slave.c |   19 +++++++++++++++----
>   1 file changed, 15 insertions(+), 4 deletions(-)

> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index 528380a..6f89caa 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
[...]
> @@ -555,12 +555,17 @@ static void dsa_slave_phy_setup(struct dsa_slave_priv *p,
>   	 */
>   	if (!p->phy) {
>   		p->phy = ds->slave_mii_bus->phy_map[p->port];
> -		phy_connect_direct(slave_dev, p->phy, dsa_slave_adjust_link,
> +		if(p->phy)

    Space is needed after *if*. Run your patches thru scripts/checkpatch.pl, 
it should detect such coding style issues.

> +			phy_connect_direct(slave_dev, p->phy, dsa_slave_adjust_link,
>   				   p->phy_interface);

    This continuation line should be realigned now, to start right under 
'slave_dev' on the previous line.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html