| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5487555C.7080103@gmail.com> Date: Tue, 09 Dec 2014 12:02:36 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Petri Gynther <pgynther@...gle.com>, netdev@...r.kernel.org CC: davem@...emloft.net Subject: Re: [PATCH 2/4 net-next] net: bcmgenet: rework Tx queue init On 03/12/14 20:11, Petri Gynther wrote: > 1. Rename bcmgenet_init_multiq() to bcmgenet_init_tx_queues() > 2. Move Tx default queue init inside bcmgenet_init_tx_queues() One minor nit, see below, once resolved, feel free to add a: Acked-by: Florian Fainelli <f.fainelli@...il.com> > > Signed-off-by: Petri Gynther <pgynther@...gle.com> > --- > drivers/net/ethernet/broadcom/genet/bcmgenet.c | 82 +++++++++++--------------- > 1 file changed, 36 insertions(+), 46 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > index 78ab733..eba310a 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > @@ -1776,78 +1776,74 @@ static int bcmgenet_init_rx_ring(struct bcmgenet_priv *priv, > return ret; > } > > -/* init multi xmit queues, only available for GENET2+ > - * the queue is partitioned as follows: > +/* > + * Initialize Tx queues This looks good to me, but same comment as David made, you are modifying the comment style, and this is no longer conforming to what the network drivers are using. -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists