netdev - Re: [PATCH] net: mvneta: fix race condition in mvneta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141208.205559.267421979148480413.davem@davemloft.net>
Date:	Mon, 08 Dec 2014 20:55:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	w@....eu
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	maggie.mae.roxas@...il.com, thomas.petazzoni@...e-electrons.com,
	gregory.clement@...e-electrons.com,
	ezequiel.garcia@...e-electrons.com
Subject: Re: [PATCH] net: mvneta: fix race condition in mvneta_tx()

From: Willy Tarreau <w@....eu>
Date: Tue, 2 Dec 2014 13:40:43 +0100

> On Tue, Dec 02, 2014 at 04:37:15AM -0800, Eric Dumazet wrote:
>> On Tue, 2014-12-02 at 04:30 -0800, Eric Dumazet wrote:
>> > From: Eric Dumazet <edumazet@...gle.com>
>> > 
>> > mvneta_tx() dereferences skb to get skb->len too late,
>> > as hardware might have completed the transmit and TX completion
>> > could have freed the skb from another cpu.
>> > 
>> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> 
>> 
>> 
>> For completeness, this bug was added in linux-3.14 and seems a stable
>> candidate.
>> 
>> Fixes: 71f6d1b31fb1 ("net: mvneta: replace Tx timer with a real interrupt")
> 
> Absolutely, we backported this one back to 3.10.

Applied, and queued up for -stable, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html